Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker: invalid template for next button #17206

Closed
4 tasks
Delagen opened this issue Dec 25, 2024 · 0 comments
Closed
4 tasks

Datepicker: invalid template for next button #17206

Delagen opened this issue Dec 25, 2024 · 0 comments
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone
19.0.2

Comments

@Delagen
Copy link
Contributor

Delagen commented Dec 25, 2024 •
edited
Loading

Describe the bug

Datepicker has invalid template for nextButton that product both user template & chevron icon in some cases

Pull Request Link

#17207

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-bnce9aau?file=src%2Fapp%2Fapp.component.html

Environment

Node: 22
Angular: 19
PrimeNg: 19.0.1

Windows

Angular version

19.x.x

PrimeNG version

v19

Node version

22.11.0

Browser(s)

Any

Steps to reproduce the behavior

  1. Specify nextIcon template
  2. Open calendar or datepicker, look at doubled arrow

image

Expected behavior

Only user or default icon if no template
@Delagen Delagen added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 25, 2024
Delagen pushed a commit to Delagen/primeng that referenced this issue Dec 25, 2024
Fix primefaces#17206 - calendar next button user template
3ef1ddf
Delagen pushed a commit to Delagen/primeng that referenced this issue Dec 25, 2024
@Delagen
Fix primefaces#17206 - calendar next button user template
4d09c44
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 25, 2024
@mertsincan mertsincan added this to the 19.0.2 milestone Dec 25, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 25, 2024
mehmetcetin01140 added a commit that referenced this issue Dec 26, 2024
@mehmetcetin01140
Merge pull request #17207 from Delagen/fix-datepicker-template
567333a 
Fix #17206 - calendar next button user template
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
PrimeNG
Status: Done
Milestone
19.0.2
Development

No branches or pull requests
2 participants
@Delagen @mertsincan