Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listbox: checkboxes have filled style applied even with global inputStyle and inputVariant set as outlined #17230

Closed
4 tasks
honboubao opened this issue Dec 27, 2024 · 0 comments · Fixed by #17231
Closed
4 tasks

Listbox: checkboxes have filled style applied even with global inputStyle and inputVariant set as outlined #17230

honboubao opened this issue Dec 27, 2024 · 0 comments · Fixed by #17231
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
19.0.6

Comments

@honboubao
Copy link
Contributor

honboubao commented Dec 27, 2024 •
edited
Loading

Describe the bug

Listbox with [multiple]="true" [checkbox]="true" creates checkboxes with [variant]="filled" even though PrimeNG.inputStyle and PrimeNG.inputVariant have the value 'outlined'.

Pull Request Link

#17231

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/stackblitz-starters-unv4zq64

Environment

Windows 10
Firefox 128.3.1esr

Angular version

19.0.5

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Insert Listbox mit multiple and checkbox properties
  2. Observe colored background of checkboxes within Listbox

Expected behavior

Checkboxes within Listbox respect the setting on PrimeNG.inputStyle and PrimeNG.inputVariant
@honboubao honboubao added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 27, 2024
honboubao pushed a commit to honboubao/primeng that referenced this issue Dec 27, 2024
fix: primefaces#17230 listbox and tree checkbox filled or outline var…
9b0330c 
…iant
@honboubao honboubao mentioned this issue Dec 27, 2024
Merged
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 27, 2024
@mertsincan mertsincan added this to the 19.0.3 milestone Dec 27, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 27, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jan 15, 2025
@mertsincan mertsincan modified the milestones: 19.1.0, 19.0.6 Jan 15, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
19.0.6
Development

Successfully merging a pull request may close this issue.

fix: #17230 listbox and tree checkbox filled or outline variant honboubao/primeng
2 participants
@honboubao @mertsincan