Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Textarea: hover border style not working because of misplaced semi-colon in CSS #17258

Closed
4 tasks
honboubao opened this issue Dec 30, 2024 · 0 comments · Fixed by #17259
Closed
4 tasks

Textarea: hover border style not working because of misplaced semi-colon in CSS #17258

honboubao opened this issue Dec 30, 2024 · 0 comments · Fixed by #17259
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
19.0.6

Comments

@honboubao
Copy link
Contributor

honboubao commented Dec 30, 2024 •
edited
Loading

Describe the bug

The hover border color is defined but not applied because of the misplaced semi-colon in line 24 which should be on line 22:

https://github.com/primefaces/primeng/blob/df745663da783e8b499db2240e843ed5a69fe899/packages/primeng/src/textarea/style/textareastyle.ts#L23..L24

Pull Request Link

#17259

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://primeng.org/textarea

Environment

Windows 10
Firefox 128.3.1esr

Angular version

19.0.5

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Add textarea element with pTextarea directive
  2. Move mouse over textarea
  3. Observe that border color does not change

Expected behavior

Border color changes on mouse over the same way it does for pInputText
@honboubao honboubao added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 30, 2024
honboubao pushed a commit to honboubao/primeng that referenced this issue Dec 30, 2024
fix: Fixes primefaces#17258 textarea style misplaced semi-colon
95104a1
@honboubao honboubao mentioned this issue Dec 30, 2024
Merged
@mertsincan mertsincan added this to the 19.0.6 milestone Jan 15, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 15, 2025
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 15, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
19.0.6
Development

Successfully merging a pull request may close this issue.

fix: Fixes #17258 textarea style misplaced semi-colon honboubao/primeng
2 participants
@honboubao @mertsincan