Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-confirmdialog - dismissableMask not working #17574

Closed
1 of 4 tasks
floreauwe opened this issue Feb 5, 2025 · 0 comments · Fixed by #17618
Closed
1 of 4 tasks

p-confirmdialog - dismissableMask not working #17574

floreauwe opened this issue Feb 5, 2025 · 0 comments · Fixed by #17618
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
19.0.7

Comments

@floreauwe
Copy link

Describe the bug

Confirm dialog with dismissableMask=true is not closing while clicking outside the dialog

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-t7pywxpe

Environment

OS: 11

Angular version

19.1.4

PrimeNG version

v19

Node version

22.12.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Open confirm dialog
  2. Click outside of the dialog

Expected behavior

Clicking outside of the dialog should trigger the close of confirm dialog because dismissableMask=true
@floreauwe floreauwe added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 5, 2025
Bock92 added a commit to Bock92/primeng that referenced this issue Feb 7, 2025
@Bock92
fix(confirm-dialog): restore dissmissable-mask property
9bc0484 
Fix: primefaces#17574
Bock92 added a commit to Bock92/primeng that referenced this issue Feb 7, 2025
@Bock92
fix(confirm-dialog): restore dissmissable-mask property
3d5cf84 
Fix: primefaces#17574
@Bock92 Bock92 mentioned this issue Feb 7, 2025
Merged
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 14, 2025
@mertsincan mertsincan added this to the 19.0.7 milestone Feb 14, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Feb 14, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
19.0.7
Development

Successfully merging a pull request may close this issue.

fix(confirm-dialog): restore dissmissable-mask property Bock92/primeng
2 participants
@mertsincan @floreauwe