Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualScroller for Autocomplete items #7442

Closed
SDLTechnology opened this issue Mar 25, 2019 · 9 comments
Closed

VirtualScroller for Autocomplete items #7442

SDLTechnology opened this issue Mar 25, 2019 · 9 comments
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@SDLTechnology
Copy link

If you have a PrimeNG PRO Support subscription please post your issue at;

https://pro.primefaces.org

where our team will respond within 4 business hours.

If you do not have a PrimeNG PRO Support subscription, fill-in the report below. Please note that
your issue will be added to the waiting list of community issues and will be reviewed on a first-come first-serve basis, as a result, the support team is unable to guarantee a specific schedule on when it will be reviewed. Thank you for your understanding.

Current Waiting Time: ~8 weeks.

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[ x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

What is the motivation / use case for changing the behavior?
When using Autocomplete with 9000 or more items the control takes 8-10 seconds to open the suggestions panel. Adding in Virtual Scrolling would make this control faster with large data. Dropdown component already support it.

Please tell us about your environment:
Windows 10, Webstorm

  • Angular version: 7.2.9

  • PrimeNG version: 7.1.0

  • Browser: all

  • Language: TypeScript 3.3

  • Node (for AoT issues): 10.15

@Laoujin
Copy link

Laoujin commented Oct 10, 2019

Is this on the roadmap?

@Laoujin
Copy link

Laoujin commented Oct 22, 2019

So... I created an implementation... Any chance this will get merged? :)

@Laoujin
Copy link

Laoujin commented Jan 15, 2020

I'm guessing there is no interest in this functionality?

There is a merge conflict now. If this PR could be merged, I shall resolve the conflict.
I assume that in order to have this merged, we'd need to buy the "professional primeNG" first?

@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label Mar 20, 2020
@brian428
Copy link
Contributor

Would be very helpful to have the same virtual scroll option that was added to Dropdown. The same issue (slow render with a large list) affects Autocomplete as well.

@agrinko
Copy link

agrinko commented Jul 2, 2020

I totally support this feature request. It's becoming critical for us now, in some instances autocomplete dropdown freezes the whole UI for 10+ seconds because there are thousands of items...

@meta-akshita-agrawal
Copy link

Yes, this is needed. The whole page gets unresponsive in my case.

@fernandocode
Copy link

This is something really important to have native support, I am trying an alternative approach, with autocomplete + virtualscroller, if someone has a working example it would be interesting to post here. 😅

@kareljuricka
Copy link

Looking forward to official support.

@yigitfindikli yigitfindikli modified the milestones: 11.3.0-Final, 11.3.1, 11.3.2 Mar 9, 2021
@yigitfindikli yigitfindikli modified the milestones: 11.3.2, 11.3.3 Apr 5, 2021
@GaurangDhorda
Copy link

@yigitfindikli As in this commit You have updated autocomplete with virtual-scroll. but I have found one minor visual effect is that in your commit on-line number 67 , you have this on

  • tag, [ngStyle]="{'height': itemSize + 'px'}" . When we use autocomplete component and sets itemSize property [ itemSize = 4 ] then based on ngStyle the height of
  • is also gona be 4px , so, we can not see proper list when autocompelete list is opened , if we set itemSize = 25 then
  • height will be 25px, and thats okay.. So for lower < 15 itemSize you need to set height of
  • default.. Otherwise inside our style.css we manuaaly have to set
  • height: auto !important , .. please update it and commit

  • Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Type: New Feature Issue contains a new feature or new component request
    Projects
    None yet
    Development

    No branches or pull requests

    10 participants