-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globally configure p-calendar firstDayOfWeek #9635
Comments
Right, and this is a breaking change from v10 not mentioned in the migration guide! Previously the firstDayOfWeek was part of locale, now it's separate. Why? What was the reasoning to separate it? At least the default should be taken from locale. And then the option to overrride it if you feel that such option is needed. Indeed, you're introducing breaking changes where there is no need for them. This applies to the calendar locale change too. You could have easily left the locale option and just add the default coming from config translations... |
Was happy to set calendars' config once for our whole app with i18n API, but as we're reaching France here, had to add firstDayOfWeek on our >100 instances too - which I could set once before PrimeNg V10. |
There is no way to set firstDayOfWeek for a p-columnFilter if its type is date. So its is cruicial to have it in PrimeNGConfig |
I have to agree with you, not having first day of week in locale is a big deal for us and requires a lot of boilerplate code to achieve what was previously a one time effort |
Any updates on integrating this in |
We need this. We bought a licence. Please fix it :-) |
Introduced by 9c6682c, related to primefaces#9635
[ ] bug report => Search github for a similar issue or PR before submitting
[X ] feature request => Please check if request is not on the roadmap already
Currently I have to set the firstDayOfWeek in every instance of p-calendar (>100 instances), ideally, I’d like to be able to set it once either in PrimeNGConfig or the new Translation setting in PrimeNGConfig.
I'm Currently using PrimeNG version: 11.0.0
The text was updated successfully, but these errors were encountered: