Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds readonly attribute to p-inputNumber #10386

Merged

Conversation

LeGorge
Copy link
Contributor

@LeGorge LeGorge commented Jul 2, 2021

  • Defaults to false
  • Does not display buttons when readonly is set
  • Updates the showcase documentation
  • Adds tests for p-inputNumber default displayability as done in other inputs
  • Adds tests for readonly rules
  • closes Add [readonly] attribute to p-inputNumber #9827

###Defect Fixes
When submitting a PR, please also create an issue documenting the error.

###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.

 - Defaults to false
 - Does not display buttons when readonly is set
 - Updates the showcase documentation
 - Adds tests for p-inputNumber default displayability as done in other inputs
 - Adds tests for readonly rules
 - closes primefaces#9827
@mertsincan mertsincan merged commit 66f0896 into primefaces:master Sep 6, 2021
@mertsincan
Copy link
Member

Hi @LeGorge,

Thanks a lot for your contribution!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add [readonly] attribute to p-inputNumber
2 participants