Refactor #12031 - Component: Responsive Overlay #12096
Conversation
mertsincan
added
the
Status: Pending Review
| } | ||
|
|
||
| ngAfterViewChecked() { | ||
| if (!this.initialized) { | ||
| this.ngAfterViewInit(); |
There was a problem hiding this comment.
Hi, this looks weird. I think it's better to create a private method and call it instead of using the component's lifecycle method.
There was a problem hiding this comment.
Hi, thanks a lot for your review! I agree with you. I'll update this line.
| export interface OverlayOptions { | ||
| style?: any; | ||
| styleClass?: string; | ||
| appendTo?: 'body' | HTMLElement | undefined; |
There was a problem hiding this comment.
Hi, I think you should also add 'self' for type
appendTo?: 'body' | 'self' | HTMLElement;There was a problem hiding this comment.
Yes, this enhancement already exists in our roadmap. We will port a structure like in PrimeReact. https://www.primefaces.org/primereact/setup/
|
|
||
| export interface OverlayOnShowEvent { | ||
| container?: HTMLElement | undefined; | ||
| target?: HTMLElement | undefined; |
There was a problem hiding this comment.
It's not the same?
target?: HTMLElement;There was a problem hiding this comment.
No, the container is an 'overlay' element like dropdown's overlay. The target is an element that manages the overlay.
Exp;
container: div.p-overlay.p-component.ng-star-inserted....
target: div.p-dropdown.p-component.p-dropdown-open.p-dropdown-clearable...
The container is an HTML element with a 'p-overlay'(mode: 'overlay') or 'p-overlay-modal'(mode: 'modal') class depending on the mode.
There was a problem hiding this comment.
Note: This line has been updated.
mertsincan
removed
the
Status: Pending Review
|
Any idea when this will be released? |
|
@paulstelzer I'm working on virtualScroller issues now. We plan to release it next week. |
Refactor #12031