Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #12157 only show emptyMessage if dataView is not loading #12158

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix #12157 only show emptyMessage if dataView is not loading #12158

merged 1 commit into from
Dec 2, 2022

Conversation

PaulSchult
Copy link

@PaulSchult PaulSchult commented Nov 9, 2022 •
edited
Loading

fix #12157

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

👋 Hi,
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 9, 2022
@PaulSchult PaulSchult mentioned this pull request Nov 9, 2022
Closed
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

👋 Hi,
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@PaulSchult PaulSchult changed the title fix: #12157 only show emptyMessage if dataView is not loading fix #12157 only show emptyMessage if dataView is not loading Nov 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

👋 Hi,
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@cetincakiroglu cetincakiroglu merged commit 2a479aa into primefaces:master Dec 2, 2022
@cetincakiroglu cetincakiroglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Dec 2, 2022
@cetincakiroglu
Copy link
Contributor

Hi @PaulSchult,

Good catch and thanks for the PR, we appreciate your effort and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataView: DataView shows Empty Message even if loading
2 participants
@PaulSchult @cetincakiroglu