Add additional properties to the ColumnFilterFormElement ngTemplateOutlet context #12312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tlet context This commit adds all relevant properties to be able to fully customize the `ColumnFilter` "filter" template to the `ColumnFilterFormElement` **ngTemplateOutlet context**. Without this, it is for example not even possible to recreate `#builtInElement` `ColumnFilterFormElement` template. This adds no breaking change! The formatting style of the context is the same as https://github.com/primefaces/primeng/blob/v14.2.1/src/app/components/table/table.ts#L2502-L2513
ThoSap
changed the title
cetincakiroglu
added
the
Status: Pending Review
|
Hi, will this make it into the next PrimeNG |
cetincakiroglu
removed
the
Status: Pending Review
cetincakiroglu
approved these changes
Dec 29, 2022
|
Hi @ThoSap, Good catch, thanks for your support and effort, keep up the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11466
This PR adds all relevant properties to be able to fully customize the
ColumnFilterfilter template to theColumnFilterFormElementngTemplateOutlet context.Without this, it is for example not even possible to recreate/customize the
#builtInElementColumnFilterFormElementtemplate.This adds no breaking change!
The formatting style of the context is the same as https://github.com/primefaces/primeng/blob/v14.2.1/src/app/components/table/table.ts#L2502-L2513