Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #12637 -- uses proper group children property in dropdown autoselect #12638

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

contra1337
Copy link

addresses #12637
test added to cover this issue, confirmed it fails prior to fix

there may be a remaining bug if the first group does not have any children but it is out of scope for what i wanted to resolve here

@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
primeng ⬜️ Ignored (Inspect) Feb 16, 2023 at 5:50AM (UTC)

@github-actions
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Jun 17, 2023
@contra1337
Copy link
Author

as there are no conflicts, I expect that this is still relevant

@cetincakiroglu cetincakiroglu added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response labels Jun 17, 2023
@cetincakiroglu cetincakiroglu merged commit a2fb8b6 into primefaces:master Jun 21, 2023
@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants