Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #13455 - TieredMenu does not show sub menus when mouse is hovered over the parent menu item #13457

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

Maran23
Copy link
Contributor

@Maran23 Maran23 commented Aug 7, 2023

Fixes: #13455

To fix the problem the isDirty flag needs to be set to true when the popup is shown or an item is clicked.
This will ensure that onItemChange(..) is called when a MenuItem is hovered by the mouse, which will mark the MenuItem as active and therefore uncover the sub MenuItems (children).

…e is hovered over the parent menu item

Regression from 28989fd
To fix the problem the isDirty flag needs to be set to true when the popup is shown or an item is clicked.
This will ensure that onItemChange(..) is called when a MenuItem is hovered by the mouse, which will mark the MenuItem as active and therefore uncover the sub MenuItems (children).
@vercel
Copy link

vercel bot commented Aug 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 5:53pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2023 5:53pm

@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test August 7, 2023 17:53 Inactive
@cetincakiroglu
Copy link
Contributor

Thanks for reporting to issue with the pr, I appreciate your effort 👍

@cetincakiroglu cetincakiroglu merged commit 1f1cad1 into primefaces:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TieredMenu: SubMenus are not uncovered on mouse hover anymore
3 participants