fix: #13560 || DropDown clear or close icon on click dropDown option show #13564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
ashikjs
force-pushed
the
issues-13560/dropdown-clear-selection-icon-open-options-modal
branch
2 times, most recently
from
4917b55 to
76ccfea
Compare
…wn options open randomly primefaces#13560
ashikjs
force-pushed
the
issues-13560/dropdown-clear-selection-icon-open-options-modal
branch
from
76ccfea to
927e25d
Compare
ashikjs
changed the title
ashikjs
changed the title
gucal
added
the
Status: Pending Review
|
Thanks a lot for your contribution! Best Regards, |
gucal
removed
the
Status: Pending Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue || #13560
After solution video for details and test result
Video for details
Code explain
Previously we was checking ONLY
DomHandler.hasClass(event.target, 'p-dropdown-clear-icon')this case event don't get all the time same element, some time it's also get path from svg element or others .
So I also check closest class has '.p-dropdown-clear-icon'