fix: #13571 | Multiselect not repositioned

[guillaume-tritsch]

fix: #13571

Explanation

The code for MultiSelect and Dropdown components closely resembles each other. However, I observed that the bug was occurring exclusively in the MultiSelect component. Upon comparing their respective code, I identified that a particular section of the MultiSelect code was never executed due to the constant state of the filtered variable being set to false. To address this issue, I introduced a code modification that ensures filtered is set to 'true' whenever the onFilterInputChange method is invoked.

In code

onFilterInputChange(event: KeyboardEvent) {
    this._filterValue = (<HTMLInputElement>event.target).value;
    this.activateFilter();
    this.filtered = true; // I add this line
    this.onFilter.emit({ originalEvent: event, filter: this._filterValue });
    this.cd.detectChanges();
}

this.cd.detectChanges() refresh the view and call ngAfterViewChecked but filtered attribut is on false, so the alignOverlay is never call.

ngAfterViewChecked() {
    if (this.filtered) {
        this.zone.runOutsideAngular(() => {
            setTimeout(() => {
                this.overlayViewChild?.alignOverlay();
            }, 1);
        });
        this.filtered = false;
    }
}

I hope my explanations are clear, and I haven't made any mistakes when reading the code.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Aug 31, 2023 8:50am

[cetincakiroglu]

Hi @guillaume-tritsch ,

Thanks for the effort and support!