Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13714 - fix dismissableMask on confirmPopup component #13721

Conversation

SoyDiego
Copy link
Contributor

Fix #13714

Now when you add dismissableMask: false in your confirmationService the confirmPopup will not close.
By default continue working as always, if you don't add the property, if you click outside, will close.

AFTER SOLUTION

Note: In the following gif, I am clicking many times and it does not close after have applied dismissableMask: false

image

fix confirmPopup

@vercel
Copy link

vercel bot commented Sep 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2023 11:21am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2023 11:21am

@vercel vercel bot temporarily deployed to Preview – primeng-ssr-test September 24, 2023 11:21 Inactive
@cetincakiroglu cetincakiroglu merged commit 7f78f00 into primefaces:master Sep 26, 2023
@MussaratAziz
Copy link

@SoyDiego @cetincakiroglu do we have this fix available in 16.4.0 ?

@SoyDiego
Copy link
Contributor Author

@SoyDiego @cetincakiroglu do we have this fix available in 16.4.0 ?

Yes now it's available. Update your project

@MussaratAziz
Copy link

MussaratAziz commented Sep 26, 2023

@SoyDiego i just did updated the v16.3.1 to 16.4.0 everything broke i have submitted an issue #13755
Also none of the components picking up themes as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dismissableMask is not working on ConfirmationPopup
3 participants