Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #9441: Re-add CSS for p-overlaypanel-shifted #9442

Merged

Conversation

dakotajd
Copy link

@dakotajd dakotajd commented Oct 22, 2020

Re-added CSS for p-overlaypanel-shifted class so that the arrow points to the correct location when the panel is up against the right edge of the screen. This CSS was (unintentionally?) removed in commit: c7dd064#diff-4166dfa8da6660ec4e195e891b761a9ce8f5e49db19ace3613ac9d66ad8e4f94L56

Note this CSS was also removed (ui should be renamed to p):

.ui-overlaypanel-shifted:after {
    margin-right: -8px;
}

.ui-overlaypanel:before {
    margin-right: -10px;
}

But I chose not to add it back, because with it, the arrow overlaps the close button slightly. Without it though, the arrow is offset from the edge on the right side of the panel slightly more than it is when it appears on the left. Perhaps this could be made dynamic in the future to adjust when the close button is/isn't showing?

See issue for more information/context.

Defect Fixes

#9441

Feature Requests

Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.

…s to the correct location when the panel is up against the right edge of the screen
@cagataycivici
Copy link
Member

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants