Issue #9441: Re-add CSS for p-overlaypanel-shifted #9442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-added CSS for p-overlaypanel-shifted class so that the arrow points to the correct location when the panel is up against the right edge of the screen. This CSS was (unintentionally?) removed in commit: c7dd064#diff-4166dfa8da6660ec4e195e891b761a9ce8f5e49db19ace3613ac9d66ad8e4f94L56
Note this CSS was also removed (ui should be renamed to p):
But I chose not to add it back, because with it, the arrow overlaps the close button slightly. Without it though, the arrow is offset from the edge on the right side of the panel slightly more than it is when it appears on the left. Perhaps this could be made dynamic in the future to adjust when the close button is/isn't showing?
See issue for more information/context.
Defect Fixes
#9441
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.