Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This closes https://github.com/github/primer/issues/664 by reducing the size of
Label--inline
.Markup used for the screenshots above:
What approach did you choose and why?
Reducing the
font-size
andpadding
makes sure the labels don't touch each other when wrapped onto multiple lines. Thefont-size: 85%;
also matches the<code>
's font size.What should reviewers focus on?
Since
Label--inline
isn't really meant to be used withIssueLabel
, I was contemplating adding a separateIssueLabel--inline
variation. But there was some talk to replaceIssueLabel
with a variation likeLabel Label--filled
. So for now usingIssueLabel Label--inline
might still be fine.Are additional changes needed?