-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update primercss.io website #315
Conversation
Is the intent to host any future Primer documentation on this site, or is it all going in our upcoming styleguide redesign? |
@mdo The intention is to host all style documentation and design guidelines in the new style guide, and for primer.io to be a 1 page overview of packages, and perhaps installation instructions, and to link to the style guide from there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a few /archive
prefix links
|
||
<title> | ||
Home · Primer | ||
</title> | ||
|
||
<link rel="stylesheet" href="/docs.css"> | ||
<link href="https://unpkg.com/primer-core/build/build.css" rel="stylesheet"> | ||
<link href="https://unpkg.com/primer-markdown/build/build.css" rel="stylesheet"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say not to rely on unpkg.com and just check in these build sources into this branch
archive/index.html
Outdated
Home · Primer | ||
</title> | ||
|
||
<link rel="stylesheet" href="/docs.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be /archive/docs.css
archive/index.html
Outdated
</footer> | ||
</div> | ||
|
||
<script src="/js/anchor.min.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs /archive
archive/index.html
Outdated
<h1>Primer</h1> | ||
<p>The CSS toolkit and guidelines that power GitHub.</p> | ||
|
||
<a href="/scaffolding/" class="btn btn-reverse"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs /archive
archive/index.html
Outdated
|
||
<nav class="masthead-nav"> | ||
<a href="/scaffolding">Docs</a> | ||
<a href="/about">About</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs /archive
archive/index.html
Outdated
</a> | ||
|
||
<nav class="masthead-nav"> | ||
<a href="/scaffolding">Docs</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs /archive
archive/index.html
Outdated
|
||
<header class="masthead"> | ||
<div class="container"> | ||
<a href="/" class="masthead-logo"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs /archive
?
archive/index.html
Outdated
<link rel="stylesheet" href="/docs.css"> | ||
|
||
<!-- Favicons --> | ||
<link rel="apple-touch-icon-precomposed" href="/img/apple-touch-icon-precomposed.png"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, but you moved the icon to archive. I think you should move it back since the new single page has it also.
Thanks @jonrohan - I realized I didn't map any of the urls and meant to comment, will fix those up. |
@jonrohan @shawnbot I tried adding a |
I'm down with moving this into |
Closing this in favor of primer/primer.github.io#1 |
Make primercss.io a 1 page overview & archive old website
It's been killing me for a while that we have such an out of date public website. Most primer modules have up-to-date style documentation that is a lot more useful than the out of date website, and it's probably not very obvious to people that those docs are there.
We're making good progress on the new documentation website and our intention was to make primercss.io a 1 pager of information with links to install and overview of packages, and then link to the new style guide documentation. This update sets us up for that.
In this pr
This is what it looks like:
For a more robust implementation we should automate the list of modules in each meta-package as well as version numbers. I think this static page will do for now, but we could probably make this a jekyll site and borrow some of the scripts we're using in the new documentation to keep this up-to-date.
To do
cc @primer/design-systems