Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v-align-baseline #324

Merged
merged 4 commits into from
Aug 22, 2017
Merged

Add v-align-baseline #324

merged 4 commits into from
Aug 22, 2017

Conversation

JasonEtco
Copy link
Contributor

Add the .v-align-baseline class, which is a vertical-align: baseline utility class.

@JasonEtco JasonEtco requested a review from broccolini August 18, 2017 22:19
@shawnbot shawnbot changed the base branch from master to dev August 18, 2017 22:23
Copy link
Member

@broccolini broccolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! Just one tiny nitpick comment but otherwise good to go!

.direction-rtl { direction: rtl !important; }

/* Set the direction to ltr */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick, can you remove the whitespace line above to be consistent with other families of utilities?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem! Happy to be more consistent. Change has been made 👍

@broccolini
Copy link
Member

@jonrohan @shawnbot I'm merging this into dev so that it goes into the next release. It's possible that since this utility was documented but didn't exist that people have applied it without it working—so I searched github/github and only found one instance of it being used in production. That will be easy to check when we update to a newer version.

@broccolini broccolini merged commit 6e170d7 into dev Aug 22, 2017
@broccolini broccolini deleted the add-v-align-baseline branch August 22, 2017 15:20
@shawnbot shawnbot mentioned this pull request Sep 20, 2017
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants