Import branch-name component from github/github #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a regex for documentation that essentially assumes ERB helpers
like `<%= octicon("x") %>` will generate an element with the `octicon`
class. cc @jonrohan
28 tasks
|
One note: we're going to address whitelisting (blacklisting?) docs test class names when we tackle #340. |
broccolini
approved these changes
Sep 25, 2017
This was referenced Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports the
branch-name(product) component from github/github.@jonrohan included in this PR are some tweaks to our docs test script: treatment of ERB helpers as the equivalent of an HTML class attribute in the markdown (for
<%= octicon() %>in particular), and some tidying up while I was in there. This should help with adding more doc tests in #340./cc @primer/ds-core