Tooltip component updates #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- overlap caret and body to prevent detached carets - adjust padding to land on whole pixels - bring in line with spacing scale where possible
so that caret overlap isn't visible and so that tooltips work better over dark as well as light backgrounds
This was referenced Nov 15, 2017
|
LOL at the issue number #404 |
|
👍 lgtm in terms of left-aligned avatar stacks +
Once this is merged in w/ the new avatar stacks, I'll test the right-aligned version! 🎉 |
This was referenced Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP tooltip component updates
Before:
After:
