Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: don't render ERB #646

Merged
merged 6 commits into from
Jan 11, 2019
Merged

docs: don't render ERB #646

merged 6 commits into from
Jan 11, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Jan 11, 2019

This marks all of our remaining fenced code blocks that contain ERB interpolations (<%= ... %>) as erb rather than html so that we don't render broken HTML. I replaced all instances of current_user.to_s with probot, but there are a ton of octicon and avatar helpers that still need to be "migrated" over to HTML (with React? /shrug).

I've also replaced a bunch of random image URLs with https://github.com/{username}.png avatar URLs.

TODO

@shawnbot shawnbot mentioned this pull request Jan 11, 2019
@shawnbot shawnbot changed the base branch from docs-link-test to release-10.10.4 January 11, 2019 22:26
@shawnbot shawnbot merged commit 2d744d7 into release-10.10.4 Jan 11, 2019
@shawnbot shawnbot deleted the docs-erb branch January 11, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant