Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate selector diff report #659

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Conversation

shawnbot
Copy link
Contributor

This adds a script, script/selector-diff-report, which:

  1. Downloads the build/data.json from the latest published version of primer
  2. Builds build/data.json in the local version of primer
  3. Diffs the .cssstats.selectors.values array (sorted) of the before and after JSON files and outputs the diff

This script should run on Travis after script/check-versions, so we should see something useful in the build log here because this branches off #498. 🤞

@shawnbot
Copy link
Contributor Author

Cool, so here is what it looks like:

80d79
< .avatar-stack
82,85d80
< .avatar-stack .avatar
< .avatar-stack .avatar:first-child
< .avatar-stack .avatar:last-child
< .avatar-stack .avatar:only-child
98,99d92
< .avatar-stack:hover .avatar
< .avatar-stack:hover .avatar:last-child
290,311d282
< .BtnGroup-form
< .BtnGroup-form:active
< .BtnGroup-form:active+.BtnGroup-form .BtnGroup-item
< .BtnGroup-form:active .BtnGroup-item
< .BtnGroup-form:active+.BtnGroup-item
< .BtnGroup-form:active+.BtnGroup-parent .BtnGroup-item
< .BtnGroup-form .BtnGroup-item
< .BtnGroup-form:first-child .BtnGroup-item
< .BtnGroup-form:focus
< .BtnGroup-form:focus+.BtnGroup-form .BtnGroup-item
< .BtnGroup-form:focus .BtnGroup-item
< .BtnGroup-form:focus+.BtnGroup-item
< .BtnGroup-form:focus+.BtnGroup-parent .BtnGroup-item
< .BtnGroup-form:hover+.BtnGroup-form .BtnGroup-item
< .BtnGroup-form:hover .BtnGroup-item
< .BtnGroup-form:hover+.BtnGroup-item
< .BtnGroup-form:hover+.BtnGroup-parent .BtnGroup-item
< .BtnGroup-form:last-child .BtnGroup-item
< .BtnGroup-form.selected+.BtnGroup-form .BtnGroup-item
< .BtnGroup-form.selected .BtnGroup-item
< .BtnGroup-form.selected+.BtnGroup-item
< .BtnGroup-form.selected+.BtnGroup-parent .BtnGroup-item
315d285
< .BtnGroup-item:active+.BtnGroup-form .BtnGroup-item
321d290
< .BtnGroup-item:focus+.BtnGroup-form .BtnGroup-item
325d293
< .BtnGroup-item:hover+.BtnGroup-form .BtnGroup-item
330d297
< .BtnGroup-item.selected+.BtnGroup-form .BtnGroup-item
335d301
< .BtnGroup-parent:active+.BtnGroup-form .BtnGroup-item
342d307
< .BtnGroup-parent:focus+.BtnGroup-form .BtnGroup-item
346d310
< .BtnGroup-parent:hover+.BtnGroup-form .BtnGroup-item
351d314
< .BtnGroup-parent.selected+.BtnGroup-form .BtnGroup-item
552,560d514
< .data-table
< .data-table tbody td
< .data-table tbody th
< .data-table tbody th
< .data-table tbody tr:last-child td
< .data-table tbody tr:last-child th
< .data-table td
< .data-table th
< .data-table th
1067,1075d1020
< .jumbotron
< .jumbotron
< .jumbotron
< .jumbotron-minitron
< .jumbotron-minitron
< .jumbotron-photo
< .jumbotron-photo::before
< .jumbotron-shadow::after
< .jumbotron-supertron
1797a1743,1745
> .p-10
> .p-11
> .p-12
1803,1806c1751,1753
< .page-section
< .page-section
< .page-section-jumplink:target
< .page-section-jumplink:target
---
> .p-7
> .p-8
> .p-9
1903a1851,1853
> .pl-10
> .pl-11
> .pl-12
1908a1859,1861
> .pl-7
> .pl-8
> .pl-9
1911a1865,1867
> .p-lg-10
> .p-lg-11
> .p-lg-12
1916a1873,1875
> .p-lg-7
> .p-lg-8
> .p-lg-9
1918a1878,1880
> .pl-lg-10
> .pl-lg-11
> .pl-lg-12
1923a1886,1888
> .pl-lg-7
> .pl-lg-8
> .pl-lg-9
1925a1891,1893
> .pl-md-10
> .pl-md-11
> .pl-md-12
1930a1899,1901
> .pl-md-7
> .pl-md-8
> .pl-md-9
1932a1904,1906
> .pl-sm-10
> .pl-sm-11
> .pl-sm-12
1937a1912,1914
> .pl-sm-7
> .pl-sm-8
> .pl-sm-9
1939a1917,1919
> .pl-xl-10
> .pl-xl-11
> .pl-xl-12
1944a1925,1927
> .pl-xl-7
> .pl-xl-8
> .pl-xl-9
1946a1930,1932
> .p-md-10
> .p-md-11
> .p-md-12
1951a1938,1940
> .p-md-7
> .p-md-8
> .p-md-9
2041a2031
> .position-lg-static
2044a2035
> .position-md-static
2048a2040
> .position-sm-static
2052a2045
> .position-xl-static
2054a2048,2050
> .pr-10
> .pr-11
> .pr-12
2059a2056,2058
> .pr-7
> .pr-8
> .pr-9
2075a2075,2077
> .pr-lg-10
> .pr-lg-11
> .pr-lg-12
2080a2083,2085
> .pr-lg-7
> .pr-lg-8
> .pr-lg-9
2082a2088,2090
> .pr-md-10
> .pr-md-11
> .pr-md-12
2087a2096,2098
> .pr-md-7
> .pr-md-8
> .pr-md-9
2094a2106,2108
> .pr-sm-10
> .pr-sm-11
> .pr-sm-12
2099a2114,2116
> .pr-sm-7
> .pr-sm-8
> .pr-sm-9
2101a2119,2121
> .pr-xl-10
> .pr-xl-11
> .pr-xl-12
2106a2127,2129
> .pr-xl-7
> .pr-xl-8
> .pr-xl-9
2108a2132,2134
> .p-sm-10
> .p-sm-11
> .p-sm-12
2113a2140,2142
> .p-sm-7
> .p-sm-8
> .p-sm-9
2189a2219,2221
> .p-xl-10
> .p-xl-11
> .p-xl-12
2194a2227,2229
> .p-xl-7
> .p-xl-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant