Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add all the .btn-purple selectors to deprecations.js #891

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Sep 10, 2019

Deleting .btn-purple in #736 actually removes a bunch of other, more specific CSS selectors from the stats. In order to appease the deprecations test script introduced in #889, we need to add all of these to the selector deprecations list for 13.0.0. Running script/test-deprecations.js on this branch yields:

i 28 selectors removed locally (compared with latest)
i 28 selectors deprecated in v13.0.0
✓ ".btn-purple" is officially deprecated
✓ ".btn-purple:focus" is officially deprecated
✓ ".btn-purple.focus" is officially deprecated
✓ ".btn-purple:hover" is officially deprecated
✓ ".btn-purple.hover" is officially deprecated
✓ ".btn-purple:active" is officially deprecated
✓ ".btn-purple.selected" is officially deprecated
✓ "[open]>.btn-purple" is officially deprecated
✓ ".btn-purple:disabled" is officially deprecated
✓ ".btn-purple.disabled" is officially deprecated
✓ ".btn-purple .Counter" is officially deprecated
✓ ".text-pending" is officially deprecated
✓ ".bg-pending" is officially deprecated
✓ ".container" is officially deprecated
✓ ".container::before" is officially deprecated
✓ ".container::after" is officially deprecated
✓ ".columns" is officially deprecated
✓ ".columns::before" is officially deprecated
✓ ".columns::after" is officially deprecated
✓ ".column" is officially deprecated
✓ ".one-third" is officially deprecated
✓ ".two-thirds" is officially deprecated
✓ ".one-fourth" is officially deprecated
✓ ".one-half" is officially deprecated
✓ ".three-fourths" is officially deprecated
✓ ".one-fifth" is officially deprecated
✓ ".four-fifths" is officially deprecated
✓ ".centered" is officially deprecated

@vercel
Copy link

vercel bot commented Sep 10, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-fix-purple-deprecations.primer.now.sh

@shawnbot shawnbot merged commit 4a60869 into release-13.0.0 Sep 10, 2019
@shawnbot shawnbot deleted the fix-purple-deprecations branch September 10, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant