Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-system-props: Add position as allowed prop for Dialog #145

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp requested review from a team and broccolinisoup March 4, 2024 14:49
Copy link

changeset-bot bot commented Mar 4, 2024

🦋 Changeset detected

Latest commit: 68b9edb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp self-assigned this Mar 4, 2024
@siddharthkp siddharthkp requested review from pksjce and removed request for broccolinisoup March 4, 2024 14:49
@siddharthkp siddharthkp changed the title Add position as allowed prop for Dialog no-system-props: Add position as allowed prop for Dialog Mar 4, 2024
@siddharthkp siddharthkp requested review from joshblack and langermank and removed request for langermank and joshblack March 4, 2024 14:55
@siddharthkp siddharthkp merged commit 0369cb8 into main Mar 5, 2024
5 checks passed
@siddharthkp siddharthkp deleted the allow-dialog-position branch March 5, 2024 11:26
@primer-css primer-css mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants