Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New duplicate icon #647

Merged
merged 9 commits into from
Aug 11, 2021
Merged

New duplicate icon #647

merged 9 commits into from
Aug 11, 2021

Conversation

Juliusschaeper
Copy link
Contributor

  • Added 16 + 24px duplicate
  • Updated copy-24 to match duplicate-24

Bildschirmfoto 2021-08-11 um 15 03 53

@Juliusschaeper Juliusschaeper requested a review from ashygee August 11, 2021 13:04
@Juliusschaeper Juliusschaeper self-assigned this Aug 11, 2021
ashygee
ashygee suggested changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@ashygee ashygee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but we should change the names of the 24px icons to just have one -24 suffix. When you push the icons from Figma it will add the sizing suffix so you don't need to have the frame named icon-24 but just icon

@ashygee ashygee self-requested a review August 11, 2021 17:14
ashygee
ashygee approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@ashygee ashygee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ashygee ashygee mentioned this pull request Aug 11, 2021
Merged
@ashygee ashygee changed the base branch from main to release-15.0.1 August 11, 2021 17:31
@ashygee ashygee merged commit d3c19ff into release-15.0.1 Aug 11, 2021
@ashygee ashygee deleted the new-duplicate-icon branch August 11, 2021 17:31
This was referenced Aug 11, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashygee ashygee ashygee approved these changes

Assignees

@Juliusschaeper Juliusschaeper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Juliusschaeper @ashygee @actions-user