Skip to content

Commit

Permalink
Remove feature-flag and extra @Aat (#5638)
Browse files Browse the repository at this point in the history
* Remove feature-flag and extra @Aat

* add skip
  • Loading branch information
kendallgassner authored Jan 31, 2025
1 parent 9b92042 commit c9b0a72
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
5 changes: 3 additions & 2 deletions e2e/components/Axe.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ const SKIPPED_TESTS = [
'components-treeview-features--contain-intrinsic-size',
'components-flash-features--with-icon-action-dismiss', // TODO: Remove once color-contrast issues have been resolved
'components-flash-features--with-icon-and-action', // TODO: Remove once color-contrast issues have been resolved
'components-filteredactionlist--default',
]

type Component = {
Expand All @@ -21,7 +22,7 @@ type Component = {

const {entries} = componentsConfig

test.describe('@aat', () => {
test.describe('Axe tests', () => {
for (const [id, entry] of Object.entries(entries as Record<string, Component>)) {
if (SKIPPED_TESTS.includes(id)) {
continue
Expand All @@ -35,7 +36,7 @@ test.describe('@aat', () => {
test.describe(id, () => {
for (const theme of themes) {
test.describe(theme, () => {
test(`${cleanedName} @aat`, async ({page}) => {
test(`@aat ${cleanedName}`, async ({page}) => {
await visit(page, {
id,
globals: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {ThemeProvider} from '..'
import {FilteredActionList} from '../FilteredActionList'
import BaseStyles from '../BaseStyles'
import Box from '../Box'
import {FeatureFlags} from '../FeatureFlags'

const meta: Meta = {
title: 'Components/FilteredActionList',
Expand Down Expand Up @@ -58,7 +57,7 @@ export function Default(): JSX.Element {
const filteredItems = items.filter(item => item.text.toLowerCase().startsWith(filter.toLowerCase()))

return (
<FeatureFlags flags={{primer_react_select_panel_with_modern_action_list: true}}>
<>
<h1>Filtered Action List</h1>
<div>Please select labels that describe your issue:</div>
<FilteredActionList
Expand All @@ -67,6 +66,6 @@ export function Default(): JSX.Element {
onFilterChange={setFilter}
sx={{border: '1px solid', padding: '8px'}}
/>
</FeatureFlags>
</>
)
}

0 comments on commit c9b0a72

Please sign in to comment.