Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay component box shadows in dark and dimmed modes #1278

Closed
pmarsceill opened this issue Jun 7, 2021 · 1 comment
Closed

Overlay component box shadows in dark and dimmed modes #1278

pmarsceill opened this issue Jun 7, 2021 · 1 comment

Comments

@pmarsceill
Copy link
Contributor

Describe the bug
Using the overlay component in dark and dimmed mode doesn't adjust the box shadow to the proper values. On Dotcom, we use different box shadows for dark modes:

image

Currently PRC uses the same shadows for dark and light modes which makes the dropdown look like it's foggy and sad in dark modes:

image

Note: As this is a public repo, please be careful not to include details or screenshots from unreleased GitHub products or features. In most cases, a good bug report should be able to describe the new component without including business logic or feature details, but if you must discuss context relating to an unreleased feature, please open an issue in the private Design Systems repo and link to it here.

To Reproduce
Use an overlay component in dark mode

Expected behavior
Same dropshadow for dark mode as we use on Dotcom

Desktop (please complete the following information):
n/a

Smartphone (please complete the following information):
n/a

@bscofield
Copy link

#1279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants