Dark mode color tweaks

[VanAnderson]

Using functional colors for shadow on the overlay. I looked at what we were doing in dotcom, and it seems to simply be using shadow.large.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 1d086e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/components	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/HYaHTs6qtaGx8c4iCBQPXAYxiCrB
✅ Preview: https://primer-components-git-vananderson-overlay-shadow-primer.vercel.app

[vdepizzol]

Hello @VanAnderson @dgreif! I'd like to make sure the Overlay patterns use the new shadows as proposed here: https://github.com/github/primer/issues/43.

I'd wait for functional variables to have updated values before merging this.

c/c @auareyou

[VanAnderson]

Hello @VanAnderson @dgreif! I'd like to make sure the Overlay patterns use the new shadows as proposed here: github/primer#43.

I'd wait for functional variables to have updated values before merging this.

c/c @auareyou

Thanks for the context there @vdepizzol!

I think @pmarsceill mentioned this fix (#1278) should be prioritized an upcoming release of the project they are working on. Unless https://github.com/github/primer/issues/43 is right around the corner, do you think we could merge this and then follow up to update it with the new functional vars?

[vdepizzol]

I think @pmarsceill mentioned this fix (#1278) should be prioritized an upcoming release of the project they are working on. Unless github/primer#43 is right around the corner, do you think we could merge this and then follow up to update it with the new functional vars?

👍 Absolutely!

@auareyou do you have a timeline of when we can fix the shadows in primer primitives?

[auareyou]

I'm on it! We'll get this updated today

[vdepizzol]

@VanAnderson for reference, @simurai is working on a Primer Primitives here: primer/primitives#135

[VanAnderson]

I'm on it! We'll get this updated today

Awesome, thanks @vdepizzol! @auareyou if you could ping me in slack once you complete that work I will make sure to expedite getting this work in :)