Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade primer/primitives to 4.4.0 #1297

Merged
merged 7 commits into from
Jun 14, 2021

Conversation

VanAnderson
Copy link
Contributor

This upgrades primer/primitives and can make some crucial design fixes.

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2021

🦋 Changeset detected

Latest commit: b451448

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/A4CFZbqZhoUHqQS1xMKZU7jcuXCC
✅ Preview: https://primer-components-git-vananderson-upgrade-primiti-bba493-primer.vercel.app

@VanAnderson
Copy link
Contributor Author

image

Also a bit concerning

@vercel vercel bot temporarily deployed to Preview June 14, 2021 17:35 Inactive
@vercel vercel bot temporarily deployed to Preview June 14, 2021 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview June 14, 2021 18:24 Inactive
@colebemis colebemis changed the title Upgrade primer/primitives to 4.3.11 Upgrade primer/primitives to 4.4.0 Jun 14, 2021
@colebemis
Copy link
Contributor

image

Also a bit concerning

Looks like this is happening on main too. I believe it's a result of using portals to render the action menu. Not a concern for this PR 👍

@vercel vercel bot temporarily deployed to Preview June 14, 2021 18:29 Inactive
@colebemis colebemis merged commit 5fb3683 into main Jun 14, 2021
@colebemis colebemis deleted the VanAnderson/upgrade-primitives-to-latest branch June 14, 2021 18:44
@github-actions github-actions bot mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants