Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkbox to useIsomorphicLayoutEffect #2116

Closed
wants to merge 6 commits into from
Closed

fix: checkbox to useIsomorphicLayoutEffect #2116

wants to merge 6 commits into from

Conversation

Swiftwork
Copy link
Contributor

Describe your changes here.

Closes #2111

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@Swiftwork Swiftwork requested review from a team and mperrotti June 6, 2022 21:30
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2022

🦋 Changeset detected

Latest commit: 1d57e8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Swiftwork 💖

@mperrotti
Copy link
Contributor

@Swiftwork - Could you open a PR as a branch directly off of this repo? Org tokens aren't propagating or being respected, so deployments aren't working for PRs from a forked repo.

@mperrotti
Copy link
Contributor

@Swiftwork - Since you're an external contributory, I cherry-picked your commits and opened a PR directly off this repo #2154

Thank you!

@mperrotti mperrotti closed this Jun 28, 2022
@Swiftwork
Copy link
Contributor Author

@Swiftwork thank you for doing the cherry-picking. I was a little confused by the request to open a branch on this PR without contributor access. It would be good to in the future allow for PR as there are a few more issues that have been detected unless you prefer me to open issue tickets instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in SSR due to useLayoutEffect in CheckBox
4 participants