SelectPanel2: Export props + pass props #4198
Conversation
🦋 Changeset detectedLatest commit: 344b48b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
@siddharthkp we would also need the Do you want me to create another issue to track that or can that also go as a part of this PR? |
| @@ -250,6 +250,7 @@ const Panel: React.FC<SelectPanelProps> = ({ | |||
| '100%': {transform: 'scale(1, 1)'}, | |||
| }, | |||
| }} | |||
| {...props} | |||
There was a problem hiding this comment.
@siddharthkp Does the typescript on props also allow StyledOverlay props to be passed through?
For context, I'm asking case where the prop maxHeight is needed to fix a styling issue with the overlay height: https://github.com/github/collaboration-workflows-flex/issues/449
<SelectPanel
height="fit-content"
maxHeight="large"
...
/>
There was a problem hiding this comment.
Does the typescript on props also allow StyledOverlay props to be passed through?
Not yet!
I'm asking case where the prop maxHeight is needed to fix a styling issue with the overlay height: https://github.com/github/collaboration-workflows-flex/issues/449
That's an interesting issue, not sure if maxHeight is the solution. Going to reply on the issue first itself
|
@ayy-bc Sure thing, I can add them to this PR |
Rollout strategy
Testing & Reviewing
Merge checklist