Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Token): Migrate to CSS modules behind feature flag Pt 2 #5271

Merged
merged 25 commits into from
Dec 4, 2024
Merged

feat(Token): Migrate to CSS modules behind feature flag Pt 2 #5271

merged 25 commits into from
Dec 4, 2024

Conversation

randall-krauskopf
Copy link
Contributor

@randall-krauskopf randall-krauskopf commented Nov 13, 2024 •
edited
Loading

Related To: https://github.com/github/primer/issues/4367

This PR is part 2 of breaking apart a larger PR into grokkable parts.

Apologies for the larger PR but there was an odd interplay with the specificity across the various components that made it hard to break this PR into smaller chunks

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8cd93d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5271 November 13, 2024 00:22 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.99 KB (+0.26% 🔺)
packages/react/dist/browser.umd.js 104.29 KB (+0.23% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5271 November 13, 2024 00:40 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5271 November 13, 2024 01:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5271 November 13, 2024 15:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5271 November 13, 2024 15:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5271 November 13, 2024 15:58 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5271 November 13, 2024 16:21 Inactive
@joshblack joshblack removed their request for review November 22, 2024 16:37
@github-actions github-actions bot temporarily deployed to storybook-preview-5271 December 2, 2024 15:40 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5271 December 3, 2024 18:54 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5271 December 3, 2024 18:57 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/353551

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 4, 2024
@randall-krauskopf randall-krauskopf added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 05db651 Dec 4, 2024
43 checks passed
@randall-krauskopf randall-krauskopf deleted the token-css-modules-base-and-token branch December 4, 2024 17:03
@primer primer bot mentioned this pull request Dec 4, 2024
Merged
francinelucca added a commit that referenced this pull request Dec 5, 2024
@francinelucca
Revert "feat(Token): Migrate to CSS modules behind feature flag Pt 2 (#…
ad3610b 
…5271)"

This reverts commit 05db651.
francinelucca added a commit that referenced this pull request Dec 5, 2024
@francinelucca
Revert "feat(Token): Migrate to CSS modules behind feature flag Pt 2 (#…
742d4a8 
…5271)"

This reverts commit 05db651.
francinelucca added a commit that referenced this pull request Dec 5, 2024
@francinelucca
Revert "feat(Token): Migrate to CSS modules behind feature flag Pt 2 (#…
f1f8177 
…5271)"

This reverts commit 05db651.
francinelucca added a commit that referenced this pull request Dec 5, 2024
@francinelucca
Revert "feat(Token): Migrate to CSS modules behind feature flag Pt 2 (#…
428e70e 
…5271)"

This reverts commit 05db651.
@francinelucca francinelucca mentioned this pull request Dec 5, 2024
Closed
13 tasks
@TylerDixon TylerDixon mentioned this pull request Dec 12, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussam-i-am hussam-i-am hussam-i-am approved these changes

@jonrohan jonrohan jonrohan approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randall-krauskopf @jonrohan @hussam-i-am