Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BaseStyles): Convert BaseStyles to CSS modules behind team feature flag #5356

Closed
wants to merge 7 commits into from
Closed

feat(BaseStyles): Convert BaseStyles to CSS modules behind team feature flag #5356

wants to merge 7 commits into from

Conversation

JelloBagel
Copy link
Contributor

@JelloBagel JelloBagel commented Dec 4, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4358

Changelog

Changed

  • Convert BaseStyles to CSS modules behind primer_react_css_modules_team feature flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 0c6494f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 18:09 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.71 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js 104.23 KB (+0.13% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 18:56 Inactive
@primer primer bot temporarily deployed to github-pages December 4, 2024 20:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 20:36 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 20:58 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 21:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 21:52 Inactive
@primer primer bot temporarily deployed to github-pages December 4, 2024 22:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 22:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 22:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 23:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 23:14 Inactive
@JelloBagel JelloBagel force-pushed the jellobagel-basestyles-css-modules branch from 7a133ed to 584547d Compare December 4, 2024 23:23
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 4, 2024 23:26 Inactive
@JelloBagel JelloBagel marked this pull request as ready for review December 4, 2024 23:58
@JelloBagel JelloBagel requested a review from a team as a code owner December 4, 2024 23:58
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 5, 2024
@JelloBagel JelloBagel marked this pull request as draft December 5, 2024 00:41
@github-actions github-actions bot temporarily deployed to storybook-preview-5356 December 5, 2024 17:33 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/353683

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@JelloBagel
Copy link
Contributor Author

JelloBagel commented Dec 5, 2024 •
edited
Loading

Remaking to clean up PR: #5361

@JelloBagel JelloBagel closed this Dec 5, 2024
@JelloBagel JelloBagel deleted the jellobagel-basestyles-css-modules branch December 5, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron Awaiting requested review from camertron camertron is a code owner automatically assigned from primer/engineer-reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan

@joshblack joshblack Awaiting requested review from joshblack

@langermank langermank Awaiting requested review from langermank

@randall-krauskopf randall-krauskopf Awaiting requested review from randall-krauskopf

Assignees
No one assigned
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JelloBagel