Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonProps should extend interfaces from StyledSystem. #536

Merged
merged 1 commit into from
Sep 9, 2019
Merged

CommonProps should extend interfaces from StyledSystem. #536

merged 1 commit into from
Sep 9, 2019

Conversation

dmarcey
Copy link
Contributor

@dmarcey dmarcey commented Sep 9, 2019

Use SystemSystem.ColorProps and StyledSystem.SpaceProps instead of StyledSystemPropTypes in declare file.

Closes #534

Merge checklist

  • Changed base branch to release branch
  • Add or update TypeScript definitions (index.d.ts) if necessary
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@vercel
Copy link

vercel bot commented Sep 9, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel vercel bot requested a deployment to staging September 9, 2019 17:04 Abandoned
@vercel vercel bot temporarily deployed to staging September 9, 2019 17:05 Inactive
emplums
emplums approved these changes Sep 9, 2019
View reviewed changes
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I'll test it with the canary once it gets merged into the release branch to double check!

@emplums emplums merged commit 74844b1 into primer:release-13.5.0 Sep 9, 2019
@dmarcey dmarcey deleted the users/dmarcey/styledSystemProps branch September 9, 2019 23:03
@emplums emplums mentioned this pull request Sep 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emplums emplums emplums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmarcey @emplums