Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flex-shrink to IconButton + tests #5467

Merged
merged 14 commits into from
Jan 17, 2025
Merged

Add flex-shrink to IconButton + tests #5467

merged 14 commits into from
Jan 17, 2025

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Dec 19, 2024 •
edited
Loading

Closes #5373

Related https://github.com/github/primer/issues/4603

Note that the VRT updates are actually bug fixes 😄

Changelog

New

Changed

  • adds flex-shrink: 0 to IconButton

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: dc392d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 19, 2024
@langermank langermank added update snapshots and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 19, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5467 December 19, 2024 20:14 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.21 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 104.51 KB (-0.02% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5467 December 19, 2024 21:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5467 December 19, 2024 21:37 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5467 December 19, 2024 21:55 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5467 January 15, 2025 21:27 Inactive
@langermank langermank marked this pull request as ready for review January 16, 2025 00:36
@langermank langermank requested review from a team as code owners January 16, 2025 00:36
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/358099

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 16, 2025
camertron
camertron approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jan 16, 2025
@langermank langermank added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit c7b109d Jan 17, 2025
43 checks passed
@langermank langermank deleted the fix-iconbutton-fle branch January 17, 2025 17:51
@primer primer bot mentioned this pull request Jan 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

@maximedegreve maximedegreve Awaiting requested review from maximedegreve maximedegreve is a code owner automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add flex-shrink: 0 by default toIconButtons
3 participants
@langermank @camertron @joshblack