Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): update examples to include primitives #5519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshblack
Copy link
Member

Noticed this when testing that our examples no longer render the button as expected now that the feature flag is gone and only CSS Modules are applied. This change updates our examples to import the expected Custom Properties from primitives so that components that are unflagged render as expected when using CSS Modules

Changelog

New

Changed

  • Update app-router example to include primitives
  • Update codesandbox example to use primitives

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is a change to our examples and not a public package

@joshblack joshblack requested a review from a team as a code owner January 9, 2025 17:24
@joshblack joshblack requested a review from TylerJDev January 9, 2025 17:24
Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 5b1abb6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 9, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.88 KB (0%)
packages/react/dist/browser.umd.js 104.19 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant