Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically publish the package when a GitHub release is published #1407

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

jonrohan
Copy link
Member

This is based on how octicons currently publishes. primer/octicons#681

The tl;dr; is that everything currently stays how it is.

  1. Changeset creates release PR
  2. Release PR is merged
  3. Changeset creates GitHub release

Previously after that last step, we would need to manually run script/publish.

This PR setups a workflow to listen for the release: published event and then prepares and then runs script/publish

@jonrohan jonrohan requested review from a team and camertron September 26, 2022 22:02
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2022

⚠️ No Changeset found

Latest commit: 65fbcca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan temporarily deployed to review-pr-1407 September 26, 2022 22:02 Inactive
@jonrohan jonrohan temporarily deployed to github-pages September 26, 2022 22:06 Inactive
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh heck yes! 🎉

@jonrohan
Copy link
Member Author

I'm fairly sure this will work, but won't know until it's used so going to merge and we'll revisit if the next release experiences problems

@jonrohan jonrohan merged commit 008bec1 into main Sep 26, 2022
@jonrohan jonrohan deleted the automatic_publishing branch September 26, 2022 23:49
keithamus pushed a commit that referenced this pull request Sep 27, 2022
…1407)

* Automatically publish the gem when release happens

* also yarn install

* create the auth files

* Use $HOME var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants