Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Tracking #2146

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Release Tracking #2146

merged 1 commit into from
Jul 24, 2023

Conversation

primer-css
Copy link
Collaborator

@primer-css primer-css commented Jul 13, 2023 •
edited
Loading

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Minor Changes

  • #2148 cbd5c84d Thanks @keithamus! - Add a linter discouraging use of in favor of Primer::Alpha::ActionMenu

  • #2123 f9119d95 Thanks @langermank! - - Use Primitive v8 color tokens

    • Add tests for compiled CSS to ensure CSS color variables have a fallback

Patch Changes

@primer-css primer-css requested review from a team and camertron July 13, 2023 20:30
@primer-css primer-css temporarily deployed to preview July 13, 2023 20:30 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023 •
edited by camertron
Loading

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Docs and Lookbook open in a browser
  • Successful integration test with GitHub.com as a primary consumer of Primer View Components
    • Install the npm release candidate in npm-workspaces/primer/
    • Use bin/vendor-gem to update primer_view_components gem
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Manually test critical paths
    • Manually test release-specific bugfixes and/or features work as described

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • All new features in this release have been tested and verified as compatible with GitHub.com
  • No noticeable regressions have been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@primer-css primer-css temporarily deployed to github-pages July 13, 2023 20:36 — with GitHub Actions Inactive
@langermank
Copy link
Contributor

Please let me know when this hits dotcom so I can review the review-lab deploy 🙌

@primer-css primer-css force-pushed the changeset-release/main branch from 1a3a56b to fbd5a26 Compare July 14, 2023 16:55
@primer-css primer-css temporarily deployed to preview July 14, 2023 16:55 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages July 14, 2023 16:59 — with GitHub Actions Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from fbd5a26 to bcdaf96 Compare July 17, 2023 21:42
@primer-css primer-css temporarily deployed to preview July 17, 2023 21:42 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages July 17, 2023 21:47 — with GitHub Actions Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from bcdaf96 to 55210d6 Compare July 21, 2023 17:18
@primer-css primer-css temporarily deployed to preview July 21, 2023 17:19 — with GitHub Actions Inactive
@primer-css primer-css temporarily deployed to github-pages July 21, 2023 17:23 — with GitHub Actions Inactive
@camertron
Copy link
Contributor

Dotcom PR (internal only): https://github.com/github/github/pull/281398

cc @langermank

@primer-css primer-css force-pushed the changeset-release/main branch from 55210d6 to f9b3725 Compare July 24, 2023 16:35
@primer-css primer-css force-pushed the changeset-release/main branch from f9b3725 to 9f6b500 Compare July 24, 2023 16:36
@camertron camertron merged commit 0604e5f into main Jul 24, 2023
@camertron camertron deleted the changeset-release/main branch July 24, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@primer-css @langermank @camertron