Always convert CSS classes to system arguments in linters #2445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
We received a Slack message last week about trying to get the
Primer/SystemArgumentInsteadOfClass
linter working in another repo. I was able to get it running eventually, but couldn't get it to find any violations, even ones I'd added manually. I discovered the linter calls::Primer::Classify::Utilities.classes_to_hash
, which bails out early if primer/view_components is configured to skip class name validation. I brought the issue to the team and learned the code returns early to avoid performance issues in production. The thing is, we never call theclasses_to_hash
method in production lol so I got rid of it. This should make the linter work without additional configuration.Integration
No changes necessary in production.
List the issues that this change affects.
Risk Assessment
Accessibility