Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add underline to link in Tooltip example #3279

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

TylerJDev
Copy link
Contributor

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Simple fix to close out https://github.com/github/accessibility-audits/issues/10112 and clear up an Axe issue.

Screenshots

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Add underline to link in Lookbook example.

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@TylerJDev TylerJDev added the skip changeset Pull requests that don't change the library output label Jan 17, 2025
@TylerJDev TylerJDev requested a review from a team as a code owner January 17, 2025 18:53
@TylerJDev TylerJDev requested a review from camertron January 17, 2025 18:53
Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: 118a614

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! Could you add a changeset when you get the chance?

@TylerJDev
Copy link
Contributor Author

@camertron, definitely can add! Just to confirm, do we usually add changesets for lookbook/preview only changes? Just wanted to double check 😄

@camertron
Copy link
Contributor

@TylerJDev woops! Wasn't thinking. Adding the "skip changeset" label is the right thing to do for preview-only changes!

@camertron camertron merged commit a3a55cf into main Jan 21, 2025
34 checks passed
@camertron camertron deleted the tylerjdev/add-underline-to-preview-example branch January 21, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants