chore: remove forge coverage command #396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The forge coverage command has been very flaky lately. Recent comments from this issue confirm others are having trouble lately as well. The command itself suggests our use of
--ir-minimum
is a workaround.Example error from https://github.com/primev/mev-commit/actions/runs/10807042835/job/29977007439?pr=395
I've consistently found the solution to this error is shortening .sol files. Ie. our main branch has
.sol
files that are just below the stack size threshold which causes this error to show up. In the case of #395, we don't have the option to refactor in order to reduce "stack too deep" errors. New code must be added.The forge coverage command itself does not add value as CI, ie. it cannot pass or fail. Therefore it shouldn't be a problem to remove from CI. At least until the foundry team addresses these compilation issues.