-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alpha
version of extension
#47
Comments
We don't currently publish alpha versions, this would be dependent on #48. After that, I think you can do something like... |
alpha
version of extension?alpha
version of extension
Internal Slack thread on how to "hack" an |
OptionsWe have the following options:
Cons: In my understanding, this is just cosmetic and adds a "Preview" to the extension page. Auto update still applies to these extensions making it a less favorable option for us as we don't want users to automatically be on the alpha.
This is what Julia lang extension does as well. Pros: Simpler to document
This is how Python extension does that. This can be a configuration argument to pin the current version or a UI selector like the python extension (how to select a specific version though?) or Using the installed Prisma CLI in the current project defaulting to main release channel. Pros: Easier to switch between different Prisma projects running on different versions
ImplementationAssuming that we choose option Current workflow
New workflow
ConsiderationsThere is a limitation in this release workflow though, any changes to An alternative can be to fix the version/binary hash in VSCode extension code to (say) "auto" and rely on the CI to make the release and revert the version to "auto". This would ensure that we can merge |
Thanks for compiling this! I like 3. the best from a user perspective, but I think that only works if the contents of the extension aren't changing that much and all logic is deferred to a separate language-server binary I think for now 2. is the way to go. I'm not sure if this is what you mean in the new workflow, but we could have 2 separate jobs running, one for alphas, one for releases. |
Option 3 is a future problem, which would need considerable amount of rework. |
That is what I mean yes, two jobs writing to two different branches though. The only consideration regarding 2 is that whoever changes Also, does anything speak against matching the Prisma version as the extension version too? |
To the contrary, there should be an issue for that. Probably makes sense to do it with this, as you will need a way to version the alpha releases. |
That's why I thought about it now, instead of writing some new logic for alpha version numbers, I can just use Prisma version. Linking the existing issue here: #93 |
* feat(alpha): via a new extension - Fixes #47 - Fixes #93 This PR is made against "alpha" and merging this should release a "new" alpha extension. * feat(alpha): incorporate release feedback - Remove the alpha branch dependency - Push only when bumping alpha - Bump @prisma/* packages when updating package.json * feat(alpha): use vsce show for extension version * Update scripts/bump-sha.sh Co-Authored-By: Jan Piotrowski <[email protected]> * feat(dev): publish Prisma Dev as a new extension - rename to dev - merge with master, adjust bump deps - add release-workflow.md * Update release-workflow.md Co-Authored-By: Jan Piotrowski <[email protected]> * fix: job name Fixes #82 Co-authored-by: Jan Piotrowski <[email protected]>
Is there a way to use the
alpha
version of this extension, that has the same validation as the currentprisma2@alpha
?The text was updated successfully, but these errors were encountered: