Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(driver-adapters): remove external wasm deps hack for napi, lift driver-adapters from query-engine/.. to libs/.. #5115

Merged
merged 21 commits into from
Jan 14, 2025
Merged

chore(driver-adapters): remove external wasm deps hack for napi, lift driver-adapters from query-engine/.. to libs/.. #5115

merged 21 commits into from
Jan 14, 2025

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Jan 10, 2025 •
edited
Loading

This PR builds on top of #5111.
It closes ORM-492.

@jkomyno jkomyno requested a review from a team as a code owner January 10, 2025 10:58
@jkomyno jkomyno requested review from aqrln and removed request for a team and aqrln January 10, 2025 10:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.098MiB 2.098MiB -193.000B
Postgres (gzip) 842.999KiB 843.464KiB -477.000B
Mysql 2.059MiB 2.059MiB -10.000B
Mysql (gzip) 828.996KiB 829.008KiB -13.000B
Sqlite 1.974MiB 1.974MiB -9.000B
Sqlite (gzip) 793.584KiB 793.512KiB 74.000B

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5115 will not alter performance

Comparing chore/lift-driver-adapters (2a2e03a) with main (deeda72)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno added this to the 6.3.0 milestone Jan 10, 2025
@jkomyno jkomyno force-pushed the chore/lift-driver-adapters branch from 737b8b6 to f7d6654 Compare January 10, 2025 14:35
@jkomyno jkomyno changed the title chore(driver-adapters): lift driver-adapters from query-engine/.. to libs/.. chore(driver-adapters): remove external wasm deps hack for napi, lift driver-adapters from query-engine/.. to libs/.. Jan 10, 2025
Base automatically changed from feat/schema-engine-wasm-init to main January 13, 2025 09:28
aqrln
aqrln reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall but there's a merge conflict in there. One it's fixed, I think it's good to merge if the CI passes.

@jkomyno jkomyno merged commit 5700ed6 into main Jan 14, 2025
368 checks passed
@jkomyno jkomyno deleted the chore/lift-driver-adapters branch January 14, 2025 12:55
@aqrln aqrln mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqrln aqrln aqrln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jkomyno @aqrln