Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline-suppressions: allow comments after ids #680

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

priv-kweihmann
Copy link
Owner

filter out any words that are not part of the
known IDs list and treat them as comments.
Like this further explanations can be added by the user

Closes #679

Pull request checklist

Bugfix

  • A testcase was added to test the behavior

filter out any words that are not part of the
known IDs list and treat them as comments.
Like this further explanations can be added by the user

Closes #679

Signed-off-by: Konrad Weihmann <[email protected]>
@priv-kweihmann priv-kweihmann force-pushed the fix/inline-suppr-comment branch from 61e79b2 to aa34945 Compare January 8, 2025 13:09
@priv-kweihmann priv-kweihmann merged commit 16124eb into master Jan 8, 2025
5 checks passed
@priv-kweihmann priv-kweihmann deleted the fix/inline-suppr-comment branch January 8, 2025 13:26
@offa
Copy link
Contributor

offa commented Jan 8, 2025

Awesome, thank you! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowing rule ids with "-" breaks (non standard) additional texts
2 participants