Implement SolidityGenerator
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han0110
force-pushed
the
feature/solidity-generator
branch
from
9440187 to
f8240eb
Compare
CPerezz
approved these changes
Sep 12, 2023
CPerezz
reviewed
Sep 12, 2023
han0110
force-pushed
the
feature/solidity-generator
branch
from
ed33ced to
d4d2ad0
Compare
han0110
commented
Sep 13, 2023
CPerezz
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
I'll apporve the PR as I don't want to keep it stucked.
TBH, I;d need more time to be able to sit down and propperly review all the logic. In any case, this is not meant to be used yet. So we can make an audit any week later this year if we feel like deploying this.
I'd add a huge disclaimer mentioning that this should not be used in production as it hasn't been yet been audited nor properly reviewed.
Aside from that, this is an awesome work Han. Amazing effort! 👏 👏
Make senses, thanks for reminding! I've added that in c51fe30 and hope it's clear! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently it allows to generate verifier in 2 way:
kand preprocessed commitments from verifying key so we could reuse verifier with different verifying key as long as theconfigureis same (with one caveat, see the second bullet in Caveats).But it assumes:
Also the transcript behaves exactly same as the
EvmTranscriptinsnark-verifier.Benchmark
For
halo2wrongmain gate with range chip, the separated verifier contract has size only 38% of the output ofsnark-verifier, and surprisingly, the gas cost is 10k lesssnark-verifiereven it has many for-loops.Caveats
--via-iris necessary when compiling the generated contract, otherwise it'd cause stack too deep. However,--via-iris not allowed to be used with--standard-json, not sure how to workaround this.configureis same, the selector compression might lead to different configuration when selector assignments are different. To avoid this we might need to update halo2 to support disabling selector compression.Acknowledgement
The template is heavily inspired by Aztec's verifier contract https://github.com/AztecProtocol/barretenberg/blob/master/sol/src/ultra/BaseUltraVerifier.sol.