Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MACI: Potential for Re-entrancy in Poll #504

Closed
baumstern opened this issue Aug 25, 2022 · 1 comment · Fixed by #522
Closed

MACI: Potential for Re-entrancy in Poll #504

baumstern opened this issue Aug 25, 2022 · 1 comment · Fixed by #522

Comments

@baumstern
Copy link
Member

Points: 5
@baumstern baumstern added the 5 label Aug 25, 2022
ctrlc03 added a commit to ctrlc03/maci that referenced this issue Sep 15, 2022
@ctrlc03
fix(maci, poll, vkregistry, accqueue): implemented fixes for audit fi…
53c5e58 
…ndings on MACI

Implemented fixes for audit findings on MACI, Poll, VkRegistry and AccQueue. 1. Fixed possible
reentrancy attacks. 2. Moved around error messages to reflect the correct error condition.  3.
changed storage variables outside of loops to reduce gas costs. 4. Added SafeERC20 to check a
transfer's return value. 5. Removed redundant boolean checks. 6. Using return value of
`maci.mergeStateAq` to update the `mergedStateRoot` variable.

fix privacy-scaling-explorations#503 fix privacy-scaling-explorations#504 fix privacy-scaling-explorations#505 fix privacy-scaling-explorations#508 fix privacy-scaling-explorations#510
@ctrlc03 ctrlc03 mentioned this issue Sep 16, 2022
Merged
@ctrlc03 ctrlc03 linked a pull request Sep 28, 2022 that will close this issue
Fix/audit (Implementing fixes for audit issues) #522
Merged
@Mikerah
Copy link

Mikerah commented Sep 29, 2022

As discussed here, we should keep track of the non enforcement of the checks-effects-interactions pattern in deployPoll in an issue (perhaps this one) and merge the rest of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/audit (Implementing fixes for audit issues) ctrlc03/maci
2 participants
@baumstern @Mikerah