feat: add start and end timestmap for poll #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ctrlc03
force-pushed
the
feat/poll-start-date
branch
from
136d303 to
f83db00
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ctrlc03
force-pushed
the
feat/poll-start-date
branch
from
f83db00 to
7686030
Compare
ctrlc03
force-pushed
the
feat/poll-start-date
branch
from
7686030 to
aeb354d
Compare
ctrlc03
force-pushed
the
feat/poll-start-date
branch
from
aeb354d to
a9ac6f2
Compare
0xmad
reviewed
Feb 7, 2025
There was a problem hiding this comment.
@ctrlc03 thanks, just one suggestion:
Let's move this to maci-contracts and re-export it in maci-sdk.
const startTime = (await signer.provider?.getBlock("latest"))?.timestamp ?? Math.floor(Date.now() / 1000);
And change getBlock to getBlockNumber.
ctrlc03
force-pushed
the
feat/poll-start-date
branch
from
a9ac6f2 to
cf67b53
Compare
0xmad
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add start and end date for polls
Related issue(s)
fix #2110
Confirmation
Important
We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.