Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add number of valid vote options #2120

Merged
merged 1 commit into from
Feb 10, 2025
Merged

feat: add number of valid vote options #2120

merged 1 commit into from
Feb 10, 2025

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Feb 10, 2025

Description

Add voteOptions public input to processMessages circuit so we can constraint votes against actual vote options per poll rather than the max vote options (capacity of the vote option tree).

Related issue(s)

fix #2115

Confirmation

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical error feel free to message the team.

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
maci-website ✅ Ready (Inspect) Visit Preview Feb 10, 2025 10:44pm

@ctrlc03 ctrlc03 self-assigned this Feb 10, 2025
@ctrlc03 ctrlc03 marked this pull request as ready for review February 10, 2025 15:07
packages/contracts/contracts/PollFactory.sol Dismissed Show dismissed Hide dismissed
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks!

@0xmad 0xmad enabled auto-merge February 10, 2025 22:34
@0xmad 0xmad force-pushed the feat/valid-vote-options branch from a35b38a to cdba5a3 Compare February 10, 2025 22:34
@0xmad 0xmad merged commit 47df18e into dev Feb 10, 2025
23 checks passed
@0xmad 0xmad deleted the feat/valid-vote-options branch February 10, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Constrain max valid vote option per poll
2 participants