Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use noirfmt to fmt nr files #20

Merged
merged 3 commits into from
Nov 25, 2024
Merged

chore: use noirfmt to fmt nr files #20

merged 3 commits into from
Nov 25, 2024

Conversation

sripwoud
Copy link
Member

@sripwoud sripwoud commented Nov 25, 2024 •
edited
Loading

Follow up of #19 (comment)

  • do not use rustfmt with dprint exec plugin to format nargo files, use directyl nargo fmt instead.

not directly related to noirfmt, but related to dprint config

  • remove dprint prettier plugin
  • add dprint pretty_yaml plugin

note that unlike in #19, the style CI check now passes

@sripwoud sripwoud requested a review from cedoor as a code owner November 25, 2024 04:14
@sripwoud sripwoud self-assigned this Nov 25, 2024
@sripwoud sripwoud added the devops 🔧 Operations management and dev tools label Nov 25, 2024
@cedoor cedoor merged commit 8690263 into main Nov 25, 2024
3 checks passed
@cedoor cedoor deleted the dprint branch November 25, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedoor cedoor cedoor approved these changes

Assignees

@sripwoud sripwoud

Labels
devops 🔧 Operations management and dev tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sripwoud @cedoor